Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import onnx model section to the book #750

Merged
merged 2 commits into from
Sep 2, 2023
Merged

Add import onnx model section to the book #750

merged 2 commits into from
Sep 2, 2023

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Sep 1, 2023

Pull Request Template

Related Issues/PRs

#200

Changes

Added a section on importing ONNX model.

Testing

Generated a book and reviewed if rendered correctly.

Luni-4
Luni-4 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@Luni-4 Luni-4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me from a semantic perspective! Thanks a lot!

Perhaps we could add some onnx examples of real networks to better understand what it is and a link to the specification, but we can do that in later PRs

louisfd
louisfd approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I like how it is clearly separated in steps.
I have only minor comments, approving in advance!

burn-book/src/import/onnx-model.md Outdated Show resolved Hide resolved
burn-book/src/import/onnx-model.md Outdated Show resolved Hide resolved
nathanielsimard
nathanielsimard requested changes Sep 1, 2023
View reviewed changes
burn-book/src/import/onnx-model.md Show resolved Hide resolved
burn-book/src/import/onnx-model.md Outdated Show resolved Hide resolved
burn-book/src/import/onnx-model.md Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit 0f0e66a into tracel-ai:main Sep 2, 2023
@nathanielsimard nathanielsimard deleted the book-onnx branch September 2, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

@louisfd louisfd louisfd approved these changes

@Luni-4 Luni-4 Luni-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antimora @Luni-4 @louisfd @nathanielsimard