Account for additional cases in Linear node conversion #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
requested changes
Aug 28, 2023
burn-import/src/onnx/coalesce.rs
Outdated
Comment on lines
148
to
157
| if peek_node.is_some() | ||
| && peek_node.unwrap().node_type == NodeType::Add | ||
| && peek_node.unwrap().inputs.len() == 2 | ||
|
|
||
| // Make sure the Add node has a value in one of its inputs and | ||
| // the other input is the output of this MatMul node | ||
| && (peek_node.unwrap().inputs[0].name == node.outputs[0].name | ||
| && peek_node.unwrap().inputs[1].value.is_some()) | ||
| | (peek_node.unwrap().inputs[1].name == node.outputs[0].name | ||
| && peek_node.unwrap().inputs[0].value.is_some()) |
There was a problem hiding this comment.
Convert the condition into a function. You can early return if peak_node.is_none(), then call unwrap only once.
nathanielsimard
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checksscript has been executed.Changes
Account for two additional cases in Linear node conversion. Previously we only converted Gemm node to a Linear module. Now, we are converting MatMul and Add optionally. See ONNX graph of 3 cases for illustration.
Testing
Add more test cases and ONNX example.