Refactor/optim #272
Merged
Refactor/optim #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
force-pushed
the
refactor/optim
branch
from
69fa7a8 to
b30278a
Compare
nathanielsimard
force-pushed
the
refactor/optim
branch
from
8dd6554 to
605a0b3
Compare
antimora
approved these changes
Apr 5, 2023
| } | ||
|
|
||
| #[derive(Serialize, Deserialize)] | ||
| #[serde(bound = "")] |
There was a problem hiding this comment.
Should the bound be empty?
There was a problem hiding this comment.
Yes, it should, because no matter the generics, Serialize and Deserialize should always be implemented.
| } | ||
|
|
||
| #[derive(Serialize, Deserialize)] | ||
| #[serde(bound = "")] |
There was a problem hiding this comment.
Same question about the bound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how optimizer works.
Now similar to modules, they have their own Record associative type to determine how their state will be saved. There is two optimizer traits, one for simpler implementations and the other more general.