Matmul + CubeCL Update #2551
Merged
Matmul + CubeCL Update #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisfd
reviewed
Nov 27, 2024
| MatmulStrategy::Cube => { | ||
| let out = init_matmul_output::<R, E>(&lhs, &rhs); | ||
| let client = &lhs.client; | ||
| cubecl::linalg::matmul::launch_ref::<R, E>( | ||
| &Default::default(), |
There was a problem hiding this comment.
Since default in cubecl is Accelerated, if you're on wgpu and have autotune disabled, it will fail?
There was a problem hiding this comment.
Since a very recent PR launch_ref of matmul in CubeCL returns a Result, so we get an error if Accelerated is not available. That way we can have a fallback here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
+ Coverage 81.85% 81.86% +0.01%
==========================================
Files 834 833 -1
Lines 106589 106465 -124
==========================================
- Hits 87247 87162 -85
+ Misses 19342 19303 -39 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.