Remove precision bridge and complete float_cast implementation for ndarray
#2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change primitive to `NdArrayTensorFloat` enum - Use `execute_with_float_dtype` macro to handle ops w/ generics based on the float enum variant
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
========================================
Coverage 82.56% 82.56%
========================================
Files 827 822 -5
Lines 106855 106964 +109
========================================
+ Hits 88226 88320 +94
- Misses 18629 18644 +15 ☔ View full report in Codecov by Sentry. |
crates/burn-ndarray/src/tensor.rs
Outdated
Comment on lines
343
to
355
| // pub(crate) fn cast_to<O: Element>(self) -> NdArrayTensor<O> { | ||
| // let array = self.array.mapv(|a| a.elem()).into_shared(); | ||
|
|
||
| // NdArrayTensor::new(array) | ||
| // } | ||
|
|
||
| // pub(crate) fn to_float(self) -> NdArrayTensorFloat { | ||
| // match E::dtype() { | ||
| // DType::F64 => NdArrayTensorFloat::F64(self.cast_to()), | ||
| // DType::F32 => NdArrayTensorFloat::F32(self.cast_to()), | ||
| // _ => unimplemented!("Invalid float type"), | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Dead code detector on point, as always 😄
nathanielsimard
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed.Related Issues/PRs
#2483 #2511
Changes
tensor.cast(dtype)tensor.dtype()method (helpful to perform to/from a type, e.g. full precision usage)float_castfor ndarray backendNdArrayTensorFloatenumexecute_with_float_dtypemacro which handles ops w/ generics based on the float enum variantTesting
Cast unit test + float ops unit tests