Make .init() method of LR schedulers return Result #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `.init()` return `Result` instead of panicking for all the schedulers except `ConstantLr`, which has nothing to check. * Update affected examples * Add check and test code for Noam LR scheduler * Clean up test code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
========================================
Coverage 82.59% 82.60%
========================================
Files 827 827
Lines 106712 106821 +109
========================================
+ Hits 88143 88238 +95
- Misses 18569 18583 +14 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
laggui
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.run-checksscript was executed withDISABLE_WGPU=1, because otherwise I would get an unrelated error similar to #1477.Related Issues/PRs
Fix #2510
Changes
Make
.init()method of LR schedulers returnResultinstead of panicking for invalid configuration.Add check and test code for Noam LR scheduler accordingly.
ConstantLris not changed because there is nothing to check.Update affected examples (text-generation & text-classification).
Clean up related test code (eliminate unnecessary constants and helper function)
Testing
DISABLE_WGPU=1 bash ./run-checks.shran with no error