Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tri mask ops return docstring #2517

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix tri mask ops return docstring #2517

merged 1 commit into from
Nov 20, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Nov 20, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

As pointed out on discord
#2450

Changes

  • Fixed the docstring for the return type (condition was the logical inverse, the mask is filled with false along the specified
    region).
  • Added examples to illustrate the usage (and expected output)

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (76e67bf) to head (a6ceaca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files         819      819           
  Lines      105667   105667           
=======================================
  Hits        87648    87648           
  Misses      18019    18019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@Jaghov Jaghov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@laggui laggui merged commit b4e8e45 into main Nov 20, 2024
11 checks passed
@laggui laggui deleted the fix/docs/tri-mask branch November 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants