Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit GEMM optimizations/bug fixes #2499

Merged
merged 16 commits into from
Nov 18, 2024
Merged

Implicit GEMM optimizations/bug fixes #2499

merged 16 commits into from
Nov 18, 2024

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Adds minor optimizations and support for tf32 to implicit GEMM, fixes some bugs I encountered while testing the changes

Testing

CUDA tests for f32 check the new tf32 feature, aligned reference backend test checks the unchecked weight loader on SPIR-V, and CUDA if tf32 is disabled.

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.88889% with 99 lines in your changes missing coverage. Please review.

Project coverage is 82.91%. Comparing base (a78597d) to head (a3e6095).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 35.00% 52 Missing ⚠️
crates/burn-jit/src/kernel/interpolate/bilinear.rs 23.52% 26 Missing ⚠️
...rates/burn-jit/src/kernel/reduce/subcube/kernel.rs 13.04% 20 Missing ⚠️
crates/burn-jit/src/kernel/reduce/tune/base.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   82.93%   82.91%   -0.02%     
==========================================
  Files         814      814              
  Lines      105251   105288      +37     
==========================================
+ Hits        87285    87296      +11     
- Misses      17966    17992      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@nathanielsimard nathanielsimard merged commit f64914b into tracel-ai:main Nov 18, 2024
11 checks passed
@wingertge wingertge deleted the opt/implicit_gemm branch November 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wingertge @nathanielsimard