Add SPIR-V compiler backend to burn-wgpu
#2386
Conversation
|
Prev Rust version is still set to 1.80 rn, it should be 1.81. That's why |
There was a problem hiding this comment.
The new option is a killer feature, thank you so much 🔥
On another note, which could be solved in a following PR; I think we should revisit the name of our feature flags and backends. To make things simple we should have:
tch=>libtorchwgpu-spirv=>vulkanwgpu=>webgpucuda-jit=>cuda
Some feature flags are meant to customize a backend, they should be specific for that backend:
cuda=>candle-cuda,libtorch-cudametal=>candle-metal,libtorch-metalopenblas=>ndarray-openblasaccelerate=>ndarray-accelerate
Essentially, we're making backends made with cubecl first class, meaning we don't need to prefix things with cubecl like cubecl-vulkan, cubecl-cuda or cubecl-fusion, but for the third-party backends, I think it's more flexible, since we won't have feature flags that may clash with our own. In that sense, we may also rename burn-jit to burn-cubecl, since it's pretty much the backend built on top of cubecl.
|
That sounds like a good idea and something I think we can do along with writing a proper CUDA readme and adding |
Gonna create an issue with the comment above. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
- Coverage 85.22% 85.22% -0.01%
==========================================
Files 786 786
Lines 104088 104088
==========================================
- Hits 88706 88705 -1
- Misses 15382 15383 +1 ☔ View full report in Codecov by Sentry. |
Pull Request Template
Checklist
run-checks allscript has been executed.Changes
Adds a feature to enable the new alternative SPIR-V compiler for the WGPU backend. When the feature is enabled the compiler defaults to SPIR-V, but can still be overriden with a generic.
Testing
New testing option has been added to run SPIR-V tests in addition to the
wgslones. All tests pass.xtask validatepasses.