Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cube/expand & fix double imports #2009

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Refactor/cube/expand & fix double imports #2009

merged 8 commits into from
Jul 12, 2024

Conversation

nathanielsimard
Copy link
Member

No description provided.

@nathanielsimard nathanielsimard requested a review from louisfd July 11, 2024 21:55
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 170 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (35345de) to head (ea84756).

Files Patch % Lines
crates/burn-cube/src/frontend/cmma.rs 0.00% 51 Missing ⚠️
crates/burn-cube/tests/frontend/ops.rs 7.31% 38 Missing ⚠️
crates/burn-cube/src/frontend/subcube.rs 59.15% 29 Missing ⚠️
crates/burn-cube/tests/frontend/cast_elem.rs 0.00% 8 Missing ⚠️
crates/burn-cube/tests/frontend/array.rs 50.00% 5 Missing ⚠️
crates/burn-cube/src/frontend/element/array.rs 20.00% 4 Missing ⚠️
crates/burn-cube/src/frontend/element/float.rs 76.47% 4 Missing ⚠️
crates/burn-cube/tests/frontend/assign.rs 50.00% 4 Missing ⚠️
crates/burn-cube/tests/frontend/trait.rs 60.00% 4 Missing ⚠️
...es/burn-cube/src/frontend/element/shared_memory.rs 72.72% 3 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         842      842           
  Lines      105132   105179   +47     
=======================================
+ Hits        88736    88778   +42     
- Misses      16396    16401    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

louisfd
louisfd approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I like the ::launch and __expand. Much better api and way to hide expand stuff

@louisfd louisfd merged commit 19f5ad7 into main Jul 12, 2024
15 checks passed
@louisfd louisfd deleted the refactor/cube/expand branch July 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisfd louisfd louisfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielsimard @louisfd