Feat: Implement ONNX RandomUniform + RandomNormal in burn-import #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 86.46% 86.41% -0.05%
==========================================
Files 746 750 +4
Lines 86297 87092 +795
==========================================
+ Hits 74616 75263 +647
- Misses 11681 11829 +148 ☔ View full report in Codecov by Sentry. |
laggui
requested changes
May 24, 2024
hexd0t
changed the title
laggui
approved these changes
May 24, 2024
|
🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed (unrelated tests fail for me, see Burn-WGPU tests fail on Windows with Radeon 6950 #1805, but the ones for the import succeed)Related Issues/PRs
Implements a part of #1714
Changes
Adds a Node for ONNX RandomUniform to burn-import.
It supports all of the operation's attributes except
seed, since I've found no way of providing a seed value to the Tensor (but since the specific Pseudorandom Generator isn't given, models cannot really rely on using fixed seeds anyways, so the impact is hopefully negligible)Testing
Created a testcase along the instructions of the contributor book. Since I've found no way of easily fixing the random seed in the testcase, it only checks the resulting tensor dimensions, not actual golden values.