Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Add not op and extend cast support to tensors #1634

Merged
merged 4 commits into from
Apr 16, 2024
Merged

[ONNX] Add not op and extend cast support to tensors #1634

merged 4 commits into from
Apr 16, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Apr 15, 2024 •
edited
Loading

Related Issues/PRs

Progress towards #1560 (should fix cast op error encountered by OP)

Changes

  • Added not ONNX op import support
  • Added cast ONNX op import support

Testing

Added unit tests for codegen and expected outputs

@laggui laggui requested a review from antimora April 15, 2024 15:56
@laggui laggui changed the title Extend cast ONNX support to tensors [ONNX] Add not op and extend cast support to tensors Apr 15, 2024
@laggui laggui mentioned this pull request Apr 15, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.91892% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.38%. Comparing base (d5f20e2) to head (4efee9d).

Files Patch % Lines
crates/burn-import/src/burn/node/unary.rs 99.04% 1 Missing ⚠️
crates/burn-import/src/onnx/dim_inference.rs 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   86.34%   86.38%   +0.03%     
==========================================
  Files         691      691              
  Lines       79545    79717     +172     
==========================================
+ Hits        68687    68867     +180     
+ Misses      10858    10850       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui mentioned this pull request Apr 15, 2024
Merged
@laggui
Copy link
Member Author

laggui commented Apr 15, 2024

Clippy fails because the generated code for the test case has too many outputs.. not sure if we should add #allow(clippy::type_complexity)] to the forward 🤔

antimora
antimora approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora
Copy link
Collaborator

Clippy fails because the generated code for the test case has too many outputs.. not sure if we should add #allow(clippy::type_complexity)] to the forward 🤔

It seems too eager here. I think it's fine the way you have it. Lets allow.

nathanielsimard
nathanielsimard approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antimora antimora mentioned this pull request Apr 15, 2024
Open
@laggui laggui merged commit 6d96e8d into main Apr 16, 2024
14 of 15 checks passed
@laggui laggui deleted the feat/onnx/cast branch April 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielsimard nathanielsimard nathanielsimard approved these changes

@antimora antimora antimora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laggui @antimora @nathanielsimard