Use num-traits for math ops instead of always using libm (for std and no-std) #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 86.39% 86.39% -0.01%
==========================================
Files 688 688
Lines 78676 78675 -1
==========================================
- Hits 67974 67973 -1
Misses 10702 10702 ☔ View full report in Codecov by Sentry. |
antimora
changed the title
laggui
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I converted core, tensor and ndarray to be no-std compatible, I used libm functions for std and no-std regardless. I think it would be better if we used std linked functions if it's
stdflag, otherwise to uselibm, which is how num_traits actually operates. This can potentially enhance performance if there are math libs take advantage of specific architecture, whereas libm is arch is generic. Also bundle size will be smaller.Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#168
Changes
Use num-traits for all math ops
Testing
run-checks.sh all