-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor, feat: clean Cargo.toml files, upgrade tch to 0.10 #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would want to run the github action checks before merging, I think the github templates should be updated to trigger on pull_request
instead of on push
. It would be appreciated if you could update it so that we can test if it actually triggers for pull requests from public forks.
Otherwise great work and thank you for your contributions 😃
Done |
I also noticed a bunch of clippy warnings about inlining format arguments. I can send in another PR after this one to fix them if you'd like @nathanielsimard |
Yes why not, but the CI is supposed to fail when there are clippy warnings. What command did you run? |
I'm actually on nightly rust, so the warnings may be new. |
Adds support for Metal Performance Shaders to the Tch backend