Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor, feat: clean Cargo.toml files, upgrade tch to 0.10 #131

Merged
merged 3 commits into from
Dec 25, 2022
Merged

refactor, feat: clean Cargo.toml files, upgrade tch to 0.10 #131

merged 3 commits into from
Dec 25, 2022

Conversation

VisualEhrmanntraut
Copy link
Contributor

@VisualEhrmanntraut VisualEhrmanntraut commented Dec 25, 2022

Adds support for Metal Performance Shaders to the Tch backend

@VisualEhrmanntraut VisualEhrmanntraut changed the title Clean Cargo.toml files, upgrade tch to 0.10 refactor, feat: clean Cargo.toml files, upgrade tch to 0.10 Dec 25, 2022
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would want to run the github action checks before merging, I think the github templates should be updated to trigger on pull_request instead of on push. It would be appreciated if you could update it so that we can test if it actually triggers for pull requests from public forks.

Otherwise great work and thank you for your contributions 😃

burn-tch/src/backend.rs Show resolved Hide resolved
@VisualEhrmanntraut
Copy link
Contributor Author

I would want to run the github action checks before merging, I think the github templates should be updated to trigger on pull_request instead of on push. It would be appreciated if you could update it so that we can test if it actually triggers for pull requests from public forks.

Otherwise great work and thank you for your contributions 😃

Done

@VisualEhrmanntraut
Copy link
Contributor Author

I also noticed a bunch of clippy warnings about inlining format arguments. I can send in another PR after this one to fix them if you'd like @nathanielsimard

@nathanielsimard
Copy link
Member

I also noticed a bunch of clippy warnings about inlining format arguments. I can send in another PR after this one to fix them if you'd like @nathanielsimard

Yes why not, but the CI is supposed to fail when there are clippy warnings. What command did you run?

@nathanielsimard nathanielsimard merged commit 85f98b9 into tracel-ai:main Dec 25, 2022
@VisualEhrmanntraut
Copy link
Contributor Author

I also noticed a bunch of clippy warnings about inlining format arguments. I can send in another PR after this one to fix them if you'd like @nathanielsimard

Yes why not, but the CI is supposed to fail when there are clippy warnings. What command did you run?

I'm actually on nightly rust, so the warnings may be new.
It's just cargo clippy

@VisualEhrmanntraut
Copy link
Contributor Author

I've actually already fixed all the warnings except this
Screenshot 2022-12-25 at 17 37 40
At
Screenshot 2022-12-25 at 17 38 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants