Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConvTranspose2d ONNX OP #1018

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Add ConvTranspose2d ONNX OP #1018

merged 6 commits into from
Nov 30, 2023

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Nov 29, 2023

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

  1. This is a continuation of WIP: burn-import/ConvTranspose initial support #884
  2. Fixes burn-import: ConvTranspose support #883

Changes

Add ConvTranspose2d ONNX op and tests.

Testing

  1. Added ONNX file test
  2. Added code gen test
  3. Tested on OCR ONNX file found here: https://github.com/kuroko1t/onnx-ocr

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me! Just some simple nits

burn-import/SUPPORTED-ONNX-OPS.md Outdated Show resolved Hide resolved
// because the output tensor is too large to compare with the expected tensor.
let output_sum = output.sum().into_scalar();

let expected_sum = -120.070_15; // from pytorch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we better clarify this comment?

@antimora antimora merged commit 947bb60 into tracel-ai:main Nov 30, 2023
9 checks passed
@antimora antimora deleted the pr/884 branch November 30, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

burn-import: ConvTranspose support
2 participants