Skip to content

performance regression in training FSRS #1669

Closed
@L-M-Sherlock

Description

Describe the bug

After upgrading from 0.12.1 to 0.13.0, the training slows down 2~3x.

For details:

To Reproduce

  1. git clone https://github.com/open-spaced-repetition/fsrs-rs
  2. run this test: cargo test --release -- training::tests::training --nocapture
  3. git checkout burn-0.12.1
  4. run the test again

Expected behavior

The tests should be finished in the same time.

Screenshots

Desktop (please complete the following information):

  • OS: Mac 13.3.1 (22E261)

Additional context

FSRS is a time-series model.

The test files in /tests/data:

collection.anki21.zip

revlog.csv

FrameGraph:

0.12.1:

flamegraph-0 12 1

0.13.0:

flamegraph-0 13 0

Metadata

Labels

performanceAnything related to performance

Type

No type

Projects

  • Status

    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions