Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the book to implement Clone for MnistBatcher in example code. #1607

Closed
tmheath opened this issue Apr 12, 2024 · 1 comment · Fixed by #1608
Closed

Update the book to implement Clone for MnistBatcher in example code. #1607

tmheath opened this issue Apr 12, 2024 · 1 comment · Fixed by #1608

Comments

@tmheath
Copy link

tmheath commented Apr 12, 2024

Currently the structure in the examples in the built book define the structure as below.

pub struct MnistBatcher<B: Backend> {
    device: B::Device,
}

But one problem prevented a suceeding build, that being Clone was not implemented.

#[derive(Clone)]
pub struct MnistBatcher<B: Backend> {
    device: B::Device,
}

After making the change building works out of the box and can serve as a starting point.
@laggui
Copy link
Member

laggui commented Apr 12, 2024

Good catch!

We just changed that recently with #1575, looks like we forgot to reflect all of the changes in the book.

I'll fix that now. Thanks again! :)

@laggui laggui mentioned this issue Apr 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing clone derive for MnistBatcher in the book tracel-ai/burn
2 participants
@laggui @tmheath