Fix unit_scale rate #608
Merged
Fix unit_scale rate #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=========================================
- Coverage 98.87% 98.6% -0.27%
=========================================
Files 9 10 +1
Lines 709 717 +8
Branches 127 128 +1
=========================================
+ Hits 701 707 +6
- Misses 5 6 +1
- Partials 3 4 +1 |
`auto` will be able to support alternative backends in future - 97a9393#commitcomment-29850169 - 97a9393#commitcomment-30466004 - related to #198
closes #599
closes #605
closes #608
casperdcl
added
to-merge ↰
casperdcl
added a commit
that referenced
this pull request
Oct 15, 2018
- fix `str.isnumeric` #605 - fix `WeakSet` `KeyError` #548, #553, #596 -> #607 - stop `tqdm_notebook` description truncation #582 -> #599 - include `unit_scale` for `rate` #608 - add `auto` -> nowarning `autonotebook` - add better postfix numeric formatting #621 - minor refactoring #609 -> #616 - update documentation - add unit tests - fix py26 CI
casperdcl
added a commit
that referenced
this pull request
Oct 15, 2018
- fix `str.isnumeric` #605 - fix `WeakSet` `KeyError` #548, #553, #596 -> #607 - stop `tqdm_notebook` description truncation #582 -> #599 - include `unit_scale` for `rate` #608 - add `auto` -> nowarning `autonotebook` - add better postfix numeric formatting #621 - minor refactoring #609 -> #616 - update documentation - add unit tests - fix py26 CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #449
tqdm/tqdm/_tqdm.py
Lines 893 to 899 in e32428c
by default, in
format_meter, the parameterrateis set to be1/self.avg_time.This
self.avg_timeis the average time of ONE iteration. So ifunit_scale>1, this rate should also be scaled, which will fix #449.Test:
Without this PR, the remaining time is wrong.
With this PR, it is correct.
Thanks to the analysis by @adrtod.