Minor code improvements #2017
Merged
Minor code improvements #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rewrite #2017 +/- ##
===========================================
- Coverage 99.83% 99.83% -0.01%
===========================================
Files 151 151
Lines 8457 8450 -7
Branches 875 871 -4
===========================================
- Hits 8443 8436 -7
Misses 3 3
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
reviewed
Apr 11, 2021
| result.extend(args) | ||
| result.extend(install_command[opts_at + 1 :]) | ||
| return result | ||
| return install_command[:opts_at] + list(args) + install_command[opts_at + 1 :] |
There was a problem hiding this comment.
again if you don't save the return value into a variable is a PITA to debug when something here is wrong
There was a problem hiding this comment.
This was not reverted, but set resolved? 🤔
jugmac00
reviewed
Apr 11, 2021
|
Reverted/adjusted all your comments, thank you! (although some reverted steps will itch me next time again :-) ) |
gaborbernat
approved these changes
Apr 11, 2021
gaborbernat
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tiny independent refactorings probably without need to be mentioned in the changelog.