Fixes for test_warp.lua #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! :) |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, two commits
(1) Fixes the test_warp scaling bug
(2) Fixes indentation in the rotation test script (that i verifies works correctly).
There is a mistake in
test_warp.lua. Try a rotation of 0 degrees and you will see that it will scale ever slightly, by around one pixel. The following thing describes the problem and shows the fix of the PR:Current:
PR:
Do not look at the colors themselves, the .GIF format might have changed them.
Look how in the current state the geometry changes with respect to the source image. And look how the geometry stays exactly on-pixel.
Luckily little harm is done as this is a test script, but this is the real only documentation that is to be found about the warp functionality, it's good to keep it correctly. I found this bug because I was implementing the warp functionality and found the way that it was used here to be erroneous.
Great package! Keep it up.