-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install command in mounted volumes on containers #84
Merged
patrickhoefler
merged 4 commits into
toolctl:main
from
enkodr:fix-installation-on-containers
Jun 6, 2022
Merged
Fix install command in mounted volumes on containers #84
patrickhoefler
merged 4 commits into
toolctl:main
from
enkodr:fix-installation-on-containers
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhoefler
previously approved these changes
Jan 25, 2022
auto-merge was automatically disabled
June 1, 2022 08:19
Head branch was pushed to by a user without write access
patrickhoefler
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
patrickhoefler
force-pushed
the
fix-installation-on-containers
branch
from
June 6, 2022 20:50
c7c2d13
to
e7211a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the installation script with
os.Rename
on mounted volumes inside containers it fails.To fix this, a new function was created that copies the content from the origin file to the destination file.