Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install command in mounted volumes on containers #84

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

enkodr
Copy link
Contributor

@enkodr enkodr commented Jan 23, 2022

When running the installation script with os.Rename on mounted volumes inside containers it fails.

To fix this, a new function was created that copies the content from the origin file to the destination file.

internal/utils/fs.go Outdated Show resolved Hide resolved
internal/utils/fs.go Show resolved Hide resolved
internal/utils/fs.go Outdated Show resolved Hide resolved
patrickhoefler
patrickhoefler previously approved these changes Jan 25, 2022
@patrickhoefler patrickhoefler enabled auto-merge (squash) April 20, 2022 16:23
auto-merge was automatically disabled June 1, 2022 08:19

Head branch was pushed to by a user without write access

Copy link
Member

@patrickhoefler patrickhoefler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patrickhoefler patrickhoefler force-pushed the fix-installation-on-containers branch from c7c2d13 to e7211a6 Compare June 6, 2022 20:50
@patrickhoefler patrickhoefler merged commit 12f074d into toolctl:main Jun 6, 2022
@enkodr enkodr deleted the fix-installation-on-containers branch June 6, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants