Var resolution for query fns/preds when in JVM #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a reader conditional to enable the use of namespace-qualified symbols as query functions or predicates, when in JVM Clojure. This allows queries using functions or predicates to be reused between Datomic and DataScript when running on the JVM. The semantics of a DataScript query are otherwise unchanged; global var resolution is only attempted as a final step before failure. The semantics when operating in a ClojureScript context are entirely unchanged, since global symbol->var resolution is not supported.
|
Thanks, good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a reader conditional to enable the use of
namespace-qualified symbols as query functions or predicates, when in
JVM Clojure. This allows queries using functions or predicates to be
reused between Datomic and DataScript when running on the JVM.
The semantics of a DataScript query are otherwise unchanged; global var
resolution is only attempted as a final step before failure.
The semantics when operating in a ClojureScript context are entirely
unchanged, since global symbol->var resolution is not supported.