Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter assertions concerning transaction entities when determining ma… #164

Merged
merged 1 commit into from
Jul 6, 2016

Conversation

ncalexan
Copy link
Contributor

…x-eid. (closes #163)

This patch ensures that max-eid is not set into the transaction
partition if there are assertions about transaction ids in the initial
collection of datoms provided to db-init.

This means that replaying transactions yields a database identical in
all ways, including the max-eid field.

…x-eid. (closes tonsky#163)

This patch ensures that max-eid is not set into the transaction
partition if there are assertions about transaction ids in the initial
collection of datoms provided to db-init.

This means that replaying transactions yields a database identical in
all ways, including the max-eid field.
@tonsky tonsky merged commit 783bba9 into tonsky:master Jul 6, 2016
@tonsky
Copy link
Owner

tonsky commented Jul 6, 2016

Awesome! Thanks

tonsky added a commit that referenced this pull request Jul 6, 2016
@tonsky
Copy link
Owner

tonsky commented Jul 6, 2016

Just pushed 0.15.1

@ncalexan ncalexan deleted the max-eid branch July 6, 2016 15:45
@ncalexan
Copy link
Contributor Author

ncalexan commented Jul 6, 2016

@tonsky you're welcome! We love DataScript and have learned a lot from it. We (a team at Mozilla) are starting a small project to build a similar Datomic-API-alike over at https://github.com/mozilla/datomish. Early days yet but we'd love to have your thoughts.

@tonsky
Copy link
Owner

tonsky commented Jul 6, 2016

No access

On Wed, Jul 6, 2016 at 9:47 PM Nick Alexander notifications@github.com
wrote:

@tonsky https://github.com/tonsky you're welcome! We love DataScript
and have learned a lot from it. We (a team at Mozilla) are starting a small
project to build a similar Datomic-API-alike over at
https://github.com/mozilla/datomish. Early days yet but we'd love to have
your thoughts.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#164 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARabJF0vveCnxycunGY1uq4OZMDyaZeks5qS84ggaJpZM4JAjFf
.

@ncalexan
Copy link
Contributor Author

ncalexan commented Jul 6, 2016

@tonsky sorry about that -- didn't realize we hadn't opened it up yet. I've added you as a collaborator.

@tonsky
Copy link
Owner

tonsky commented Jul 6, 2016

Nice! I already smell CREATE TABLE EAVT; :))

Do you plan to reuse any parts of DataScript code? I think query engine
would be nice to have, but I’m not sure how easy it’d be to reuse it. Do
you plan queries at all?

On Wed, Jul 6, 2016 at 9:52 PM Nick Alexander notifications@github.com
wrote:

@tonsky https://github.com/tonsky sorry about that -- didn't realize we
hadn't opened it up yet. I've added you as a collaborator.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#164 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARabLtTwXHbjTlJkY8c2vJ_C5c3jGVhks5qS888gaJpZM4JAjFf
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity and transaction id partitions not respected in db-init
2 participants