Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:db.unique/identity doesn't merge with JS API #153

Closed
terinjokes opened this issue Mar 23, 2016 · 3 comments
Closed

:db.unique/identity doesn't merge with JS API #153

terinjokes opened this issue Mar 23, 2016 · 3 comments

Comments

@terinjokes
Copy link

Marking a schema as containing a unique identity doesn't merge the entities with the JS API. I've created a reproducible test case at https://gist.github.com/terinjokes/a5003ab475a6fb5eddaa.
@typeetfunc
Copy link

@terinjokes
https://tonicdev.com/parabellum06-94/56f396a75d25f21100563b7d
In schema all string transformed to keyword.
However, string in entities are not transformed.
":my/tid" !== :my/tid
Just do not use keyword-like string as attributes.

@terinjokes
Copy link
Author

@typeetfunc thanks, I'll avoid using keywords there.

typeetfunc pushed a commit to typeetfunc/datascript that referenced this issue Mar 26, 2016
Avoid keywordize attributes in schema->clj(closes tonsky#153)
d4acd8f
@typeetfunc typeetfunc mentioned this issue Mar 26, 2016
Merged
tonsky added a commit that referenced this issue Apr 1, 2016
@tonsky
Merge pull request #155 from typeetfunc/master
4ed36c1 
Avoid keywordize attributes in schema->clj(closes #153)
@tonsky
Copy link
Owner

tonsky commented Jul 6, 2016

Just pushed 0.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@terinjokes @tonsky @typeetfunc