Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): implement proposal #19 #29

Merged
merged 1 commit into from
Aug 28, 2017
Merged

refactor(all): implement proposal #19 #29

merged 1 commit into from
Aug 28, 2017

Conversation

ordian
Copy link
Member

@ordian ordian commented Aug 28, 2017

Closes #19 (again).

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #29 into master will decrease coverage by 0.47%.
The diff coverage is 92.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   91.14%   90.67%   -0.48%     
==========================================
  Files          21       21              
  Lines        1412     1308     -104     
==========================================
- Hits         1287     1186     -101     
+ Misses        125      122       -3
Impacted Files Coverage Δ
src/lib.rs 0% <ø> (-100%) ⬇️
src/parser/trivia.rs 81.48% <0%> (+0.71%) ⬆️
src/key.rs 85.71% <100%> (-9.29%) ⬇️
src/parser/document.rs 93.05% <100%> (ø) ⬆️
src/formatted.rs 96.07% <100%> (-1.04%) ⬇️
src/document.rs 100% <100%> (+1.78%) ⬆️
src/parser/mod.rs 96.49% <100%> (ø) ⬆️
src/array_of_tables.rs 92% <100%> (+7.68%) ⬆️
src/value.rs 87.3% <75%> (-0.39%) ⬇️
src/table.rs 87.64% <88.09%> (-5.76%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a982379...80ba274. Read the comment docs.

@ordian
Copy link
Member Author

ordian commented Aug 28, 2017

bors r+

bors bot added a commit that referenced this pull request Aug 28, 2017
29: refactor(all): implement proposal #19 r=ordian a=ordian
@bors
Copy link
Contributor

bors bot commented Aug 28, 2017

@bors bors bot merged commit 80ba274 into master Aug 28, 2017
@bors bors bot deleted the dev branch August 28, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant