Asynchronous Windows named pipes #311
Conversation
Non blocking poll. 1000 times faster than current implementation. 40% faster than sockets for local connections.
Also converted safe imports of mscvrt and ssl to delayed imports. There is no need to import modules that in many use cased will not be needed. Planning to do the same for remaining safe_imports
Avoid importing PyWin32 modules, even with safe_import, when they are not used. Tested all with Python 2.7, 3,6, 3.7. All work fine. I am done with this PR.
|
Tested all with Python 2.7, 3,6, 3.7. All work fine. I am done with this PR. |
|
Hey, awesome, thanks! I will merge without the last commit (while it might be slightly better in terms of import times, I don't think it's very idiomatic and worth the benefit). |
|
I am fine with that. Just for the record the main benefit of removing the safe-imports is not to improve import times but to avoid importing modules that are not used altogether. For example a broken pywin32 installation could make rpyc unusable. safe-import still imports the module if it is available. PyWin32 modules are Windows dlls that are unnecessary loaded into the python process. |
|
I see. In the long-term, I think this should be solved by better separation of imports (i.e. putting this class and its import dependencies in a separate module that is imported by the user directly), or lazy imports (if python ever supports it natively, or maybe by patching the |
|
|
Non blocking poll. 1000 times faster than current implementation. 40% faster than sockets for local connections.