Maintain compatibility of code-tuples between Python versions 3 < .. < 3.7 and > 3.8 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…< 3.7 and > 3.8 Enables teleportation between e.g Python 3.7 and Python 3.8. Of course the changed opcodes pose a problem too, but in many cases it just works. Closes: tomerfiliba-org#370.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables teleportation between e.g Python 3.7 and Python 3.8.
Of course the changed opcodes pose a problem too, but in many cases it just works.
Closes: #370.
I have tested:
test_teleportation.pyruns by 3.8, connects to 3.8 server.test_teleportation.pyruns by 3.8, connects to 3.7 server.test_teleportation.pyruns by 3.7, connects to 3.8 server.test_teleportation.pyruns by 3.7, connects to 3.7 server.def f(n, /): return n + 1to 3.7 server. The teleported function doesn't respect positional-only arguments (as expected): you can callteleported_f(n=1)but can't callf(n=1).@comrumino do you want me to add the cross-version testing somehow? I'm not sure how to do it (I don't know how your CI runs. Do I have many versions of Python installed? Do all of them have
rpycinstalled?)