-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set pane title if provided in config file #891
Conversation
This is great, @augustelalande! A few initial bits of feedback:
Do you have any thoughts, @akofink? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, and it seems to work as expected. Very cool improvement! 💯
I agree with all of @ethagnawl's points as well. It looks like only tmux 2.6 and above will support this, from here:
CHANGES FROM 2.5 TO 2.6, 05 October 2017
* Add select-pane -T to set pane title.
Thanks for the feedback guys. I think I've implemented all the changes, with two caveats
My proposal would be once this gets merged, to add configuration options to the tmuxinator config, to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to merge to me. Nice work! The tests look great. 🙌
My one remaining bit of feedback is that the README should specify the minimum version of tmux required to make use of this functionality. Otherwise, LGTM. Thanks again, @augustelalande! |
Done |
Thanks for this awesome improvement @augustelalande! 🦖 |
Pane titles are a commonly desired feature in tmux sessions (e.g. https://stackoverflow.com/questions/47800955/how-to-set-pane-titles-with-tmuxinator), but not explicitly supported by tmuxinator (although a pane can be named).
To pass a title to tmux it is generally required to use a somewhat hacky method, and run the command:
printf '\033]2;%s\033\\' '<title>'
(tmux select-pane -T <title>
is also supported).Since tmuxinator already provides the ability to define a pane title, I thought I would take it a step further and pass that title to tmux. As it stands right now, tmux would still need to be configured with the appropriate settings to display the title, e.g.:
but at least the title will be passed directly from the tmuxinator config, to tmux. As a follow up to this PR, we could make the pane title configuration part of the tmuxinator config.