Add workflow for GitHub Actions #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btcbee
commented
Aug 12, 2022
| bash autogen.sh | ||
| bash ./configure && make && sudo make install | ||
| cd .. | ||
| tmux -V |
There was a problem hiding this comment.
No automatic check here to verify that the version built matches the version requested, because sometimes the prerelease was not removed before the release was cut (e.g. v3.1). 😭
|
This is great, @btcbee. Thanks for putting it together! I'll try to give this a proper review and get it running later this week. Also, yes, I'd say the Travis config file should be removed as part of this integration. |
btcbee
force-pushed
the
master
branch
3 times, most recently
from
4975340 to
8ed3afe
Compare
|
Fix typo
|
This looks great, @btcbee. Thanks again. Does anyone else have any thoughts, @tmuxinator/tmuxinator? |
|
Thanks again, @btcbee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic GHA workflow to get the automatic test suite running again. I'm sure there's room for optimization, but this should be a good start.
Sample test run: https://github.com/btcbee/tmuxinator/actions/runs/2849166648
Should the
.travis.ymlfile be removed in the same PR?@ethagnawl
Fixes #850