@endorama It's been a while since I looked at the linked issue. Might people have come to rely on the existing/"broken" behavior or is this only a bug fix?

@ethagnawl the linked issue is requesting a bug fix. The issue describes that the current documented functionality does not work at all. At least, that's what it evolved into.

@ethagnawl AFAICT that functionality never worked as intended, and I don't think can be used like this.

But if you can provide some more informations on the attach? method this should be clearer.

My intent with the unless attach? check was to avoid that multiple shell connected to the same tmux instance would each trigger the on_project_exit hook on session detach. With that check instead the on_project_exit is never triggered, and I would consider this a bug.

I just reviewed the linked thread and tested this locally. I can confirm that everything appears to be working as expected: on_project_exit is run (once) on tmux detach, C-d and tmux kill-session ....

This fix gets a 👍 from me.

Any thoughts, @adamstrickland?