Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop factory_girl, introduce factory_bot #604

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Drop factory_girl, introduce factory_bot #604

merged 1 commit into from
Mar 27, 2018

Conversation

geor-g
Copy link
Contributor

@geor-g geor-g commented Mar 25, 2018 •
edited
Loading

This library was renamed, see [1] for details.

[1] https://github.com/thoughtbot/factory_bot/blob/master/NAME.md

@ethagnawl
Copy link
Member

@ge-fa Per the contributing guidelines, would you mind adding a summary of these changes to CHANGELOG.md? Otherwise, LGTM.

Thanks!

@geor-g geor-g force-pushed the drop-factory_girl-introduce-factory_bot branch from 1b52a4d to bbc1a54 Compare March 26, 2018 20:57
@geor-g
Copy link
Contributor Author

geor-g commented Mar 26, 2018 •
edited
Loading

Sure, sorry, I've overlooked this. Fixed.

Edit: Rebased and solved conflict.

@geor-g geor-g force-pushed the drop-factory_girl-introduce-factory_bot branch from bbc1a54 to 2bd994c Compare March 26, 2018 21:02
@ethagnawl ethagnawl mentioned this pull request Mar 26, 2018
Merged
@ethagnawl ethagnawl merged commit b0ece95 into tmuxinator:master Mar 27, 2018
alin23 pushed a commit to alin23/tmuxinator that referenced this pull request Apr 25, 2018
@alin23
Drop factory_girl, introduce factory_bot (tmuxinator#604)
7e0c74b 
This library got renamed, see [1] for details.

[1] https://github.com/thoughtbot/factory_bot/blob/master/NAME.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geor-g @ethagnawl