Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 - Moving role_arn from credentials to config #189

Closed
popei69 opened this issue May 30, 2019 · 4 comments
Closed

S3 - Moving role_arn from credentials to config #189

popei69 opened this issue May 30, 2019 · 4 comments
Labels
breaking enhancement

Comments

@popei69
Copy link
Contributor

popei69 commented May 30, 2019

Enhancement Suggestion / Bug Report

Going further in #175, the fix seems to rely on credentials file only for source_profile and role_arn fields.

However, AWS suggests to use config to setup source_profile and role_arn. Source: Assuming an IAM Role in the AWS CLI

Steps which explain the enhancement or reproduce the bug

  1. Setup AWS with source_profile and role_arn setup in config file as expected by AWS from their documentation.
  2. Run Rome

Current behavior

Access Denied

Why would the enhancement be useful to most users

Using config file instead of credentials file for this specific request would avoid to support duplicated configuration between those two files.

Rome version:

0.21.0.58 - Romam uno die non fuisse conditam.

OS and version:

macOS 10.14.4
@tmspzz
Copy link
Owner

tmspzz commented May 30, 2019

Yes, it relies on ~/.aws/credentials. I was under the impression that was the correct place but apparently it's not. I'll address this asap.

@popei69 popei69 mentioned this issue Jun 4, 2019
Merged
@popei69
Copy link
Contributor Author

popei69 commented Jun 4, 2019

@blender I had a look into it and created a PR for it #190.

It ran in my local environment with having the source_profile and role_arn only in config file instead of credentials. I'm not expert into Haskell, please let me know if I miss anything.

Thanks

@tmspzz
Copy link
Owner

tmspzz commented Jun 5, 2019 •
edited
Loading

@popei69 Thanks for your contribution, the new version is out https://github.com/blender/Rome/releases/tag/v0.23.0.60

@tmspzz tmspzz closed this as completed Jun 5, 2019
@popei69
Copy link
Contributor Author

popei69 commented Jun 5, 2019

@blender No worries, happy to help! Thanks for the quick release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmspzz @popei69