Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat decorative img #28

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Feat decorative img #28

merged 2 commits into from
Jan 27, 2023

Conversation

silverli
Copy link
Collaborator

@silverli silverli commented Jan 27, 2023 •
edited
Loading

  • creates 2 distinct entries for decorative vs informative img
  • expands/edits some of the writing in each entry (please edit/revise as you see fit!)
  • adds a demo page http://localhost:4000/demos/image-decorative/ to test out aria-hidden="true" on decorative images. Lindsay thinks alt empty alone should work in all modern and even post-modern version browsers/screen reader combos

@silverli
feat: adds decorative image section separate from informative
60c263b 
- edits a few examples
- renames filenames
@silverli
feat: adds demo page for testing decorative img
a8ff49c 
(this is only for the purposes of testing and deciding on if aria-hidden should be included in the write up. delete these files when we come to consensus).
@charlietriplett charlietriplett merged commit 60318fc into main Jan 27, 2023
@charlietriplett charlietriplett deleted the feat--decorative-img branch January 27, 2023 22:44
charlietriplett pushed a commit that referenced this pull request Jan 27, 2023
Revert "Feat decorative img (#28)"
a445032 
This reverts commit 60318fc.
@silverli silverli restored the feat--decorative-img branch January 27, 2023 23:01
silverli added a commit that referenced this pull request Jan 27, 2023
@silverli
Revert "Feat decorative img (#28)"
a7fc110 
This reverts commit 60318fc.
@silverli silverli deleted the feat--decorative-img branch February 9, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlietriplett charlietriplett charlietriplett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverli @charlietriplett