profile: read contacts fields safely #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types. It checked for the tags on values found in the map. However, it's possible for values to be null, in which case trying to grab the head would crash at runtime. Here, we update the typecheck to check on the full value as opposed to just the head. Since this crashing code might have run in response to a contacts subscription update, killing the subscription, we add a bit of logic to +on-load to ensure that the contacts subscription gets set up again if needed.
|
we can get it out quicker if you merge to staging |
|
The change that was dangerous was in #4267, which is only on develop, hasn't made it to staging yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types. It checked for the tags on values found in the map. However, it's possible for values to be null, in which case trying to grab the head would crash at runtime.
Here, we update the typecheck to check on the full value as opposed to just the head.
Since this crashing code might have run in response to a contacts subscription update, killing the subscription, we add a bit of logic to +on-load to ensure that the contacts subscription gets set up again if needed.