Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacman-f: add alias page; pacman-files: update page #14858

Merged
merged 10 commits into from
Nov 30, 2024
Merged

pacman-f: add alias page; pacman-files: update page #14858

merged 10 commits into from
Nov 30, 2024
+18 −11

Conversation

angadsgrover
Copy link
Contributor

@angadsgrover angadsgrover commented Nov 17, 2024 •
edited
Loading

#14003

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Nov 17, 2024
kbdharun
kbdharun approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM after the above suggestion.

Also, if possible can we change the page description to something like Perform file operations in the Arch Linux package manager utility.?

@angadsgrover
Copy link
Contributor Author

something like Perform file operations in the Arch Linux package manager utility.?

Sure I could do that, but we haven't changed the file descriptions of the updated pacman-remove and pacman-sync command pages. Would you want me to change their descriptions too?

@github-actions github-actions bot added the tooling Helper tools, scripts and automated processes. label Nov 19, 2024
@angadsgrover @sebastiaanspeck
Update scripts/wrong-filename.sh
5c039dc 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
sebastiaanspeck
sebastiaanspeck reviewed Nov 19, 2024
View reviewed changes
pages/linux/pacman-files.md Outdated Show resolved Hide resolved
pages/linux/pacman-files.md Outdated Show resolved Hide resolved
pages/linux/pacman-files.md Outdated Show resolved Hide resolved
@angadsgrover @sebastiaanspeck
Mnemonic suggestions
5526077 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
sebastiaanspeck
sebastiaanspeck requested changes Nov 24, 2024
View reviewed changes
pages/linux/pacman-files.md Outdated Show resolved Hide resolved
pages/linux/pacman-files.md Outdated Show resolved Hide resolved
@angadsgrover @sebastiaanspeck
Apply suggestions from code review
c36d4a3 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@Managor Managor mentioned this pull request Nov 14, 2024
Closed
8 tasks
@Managor
Copy link
Collaborator

Managor commented Nov 29, 2024 •
edited
Loading

@sebastiaanspeck Can you approve and merge?

@sebastiaanspeck sebastiaanspeck merged commit a75d875 into tldr-pages:main Nov 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@karthik-script karthik-script karthik-script approved these changes

@Managor Managor Managor approved these changes

@kbdharun kbdharun kbdharun approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s). tooling Helper tools, scripts and automated processes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@angadsgrover @Managor @sebastiaanspeck @kbdharun @karthik-script @spageektti