Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape variables to support spaces in paths #187

Closed
jbnicolai opened this issue Jul 6, 2014 · 3 comments
Closed

Escape variables to support spaces in paths #187

jbnicolai opened this issue Jul 6, 2014 · 3 comments
Labels
bug

Comments

@jbnicolai
Copy link
Contributor

I think we all agree that spaces in paths are a bad idea 😄. I suggest we still make the script a bit more robust by handling them correctly though, and properly quote all dereferenced variables.

Would a PR for this be welcome?
@bitdivine
Copy link

With my security hat on I would say that shell variables should always, always, ALWAYS be quoted unless you are going out of your way to be pwned. With my realistic one I reduce that to "almost always". Would a pull request be welcome?

@shadowspawn
Copy link
Collaborator

On a related note, following the advice fromShellCheck (see #465) would likely address spaces in paths and more.

@shadowspawn
Copy link
Collaborator

Fixed in v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tjwebb @jbnicolai @bitdivine @shadowspawn