Fix SrcSet & CSS issues #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not proper implemented srcset fixed with tag 'srcSet' so now all of your images load.
Added 'STYLE' to getTextContent & Added HTMLSourceElement to 'srcset'. (most websites use a source element too aswell)
Found that only srcSet was present always on all browsers. If this is not universal then please address it
Causes conflicts with HTML Character Entities and maybe some other things. For now I will comment this out
|
@quotingg this did not fix the srcset rewriting issues, the other stuff is good though |
explained: use regex substitution to get url then rewrite it very dynamic
re-adding this just in case
Makes all URLS supported and they can be http now.
ok this actually supports all urls now lol before things like butterflies.png didn't load and needed to be /butterflies.png
i have no idea regex being dumb rn have to revert
This will capture any srcsets that have not been captured at first.
|
hey, @Percslol i made some changes the srcset rewriting issues should be fixed now |
|
@quotingg the srcset regex still seems broken
|
instead of trying to get urls just get everything before srcset descriptors
Allow for things like 1000w.
makes sure if there isn't any descriptors are not present rewrite it
lol accidently did src instead of str
|
@Percslol okay now finally it should work |
|
seems to work now, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes issues with both srcset images and styles not being rewritten
also added HTMLSourceElement to srcset since it wasn't added for some reason?