Skip to content

[BUG] Undefined Behaviour in hsearch and reqs #470

Open
@anon767

Description

Static Analysis Reports

Hi, I checked the code with a static analyzer and UBSAN and have some findings to report.

Tinyproxy version

Git Master

In hsearch.c:

  • hsearch.c:85:36: runtime error: applying zero offset to null pointer
  • hsearch.c:85:49: applying non-zero offset 24 to null pointer

in reqs.c:

  • reqs.c:349:15: sscanf() sscanf has no field width limits and may crash depending on the input
  • reqs.c:380:48: Passing NULL as the last typed argument to a variadic function leads to UB.

Do these issues need to be addressed?

Kind regards and thanks in advance

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions