Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2240: add new understanding-editor-loads.adoc to how-to-guide section #3047

Merged
merged 7 commits into from
Jan 30, 2024
Merged

DOC-2240: add new understanding-editor-loads.adoc to how-to-guide section #3047

merged 7 commits into from
Jan 30, 2024

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Jan 18, 2024 •
edited
Loading

Ticket: DOC-2240

Changes:

  • added new understanding-editor-loads.adoc to how-to-guide section.

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • Changelog entry added
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • Files removed have been deleted, not just excluded from the build (if applicable)
  • (New product features only) Release Note added

Review:

  • Documentation Team Lead has reviewed

kemister85
kemister85 commented Jan 18, 2024
View reviewed changes
Copy link
Contributor Author

@kemister85 kemister85 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Links have been updated and final copy edits verified.
  • Un-block when GMT have approved

TheSpyder
TheSpyder approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While making my suggestions I came up with a new question to include in the list.

what if the editors I create are not visible? and the answer editors within hidden sections still count as an editor load against your plan or something like that.

modules/ROOT/pages/understanding-editor-loads.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/understanding-editor-loads.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/understanding-editor-loads.adoc Outdated Show resolved Hide resolved
kemister85 and others added 3 commits January 30, 2024 10:19
@kemister85 kemister85 marked this pull request as ready for review January 30, 2024 04:18
@kemister85 kemister85 requested a review from a team as a code owner January 30, 2024 04:18
ShiridiGandham
ShiridiGandham approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit 34bec60 into release/docs-6 Jan 30, 2024
5 checks passed
@kemister85 kemister85 deleted the hotfix/6/DOC-2240 branch January 30, 2024 04:24
MitchC1999 added a commit that referenced this pull request Feb 9, 2024
@MitchC1999 @kemister85
@TheSpyder @FarzadHayat @tiny-ben-tran
DOC-2283: Bring live 6 changes into staging 7 (#3064)
3eca689 
* DOC-1020: add `language_load` option to `ui-localization.adoc` page. (#3027)

* DOC-1020: add  option to  page that configures whether additional plugin/theme languages are loaded when bundling.

* DOC-1020: updates to language_load options and admons.

* DOC-1020: copy edits and improvements.

* Update modules/ROOT/partials/configuration/language_load.adoc

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

* Update changelog.md

* Update modules/ROOT/partials/configuration/language_load.adoc

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

* Update modules/ROOT/partials/configuration/language_load.adoc

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

---------

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

* DOC-2178: add fix to  for  when inserting template. (#3043)

* DOC-2201: Added link to `ai.adoc` to direct users to the AI Assistant demo. (#3044)

* DOC-2178: add fix to  for  when inserting template.

* DOC-2201: Added link to  to direct users to the AI Assistant demo.

* Update modules/ROOT/pages/ai.adoc

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

---------

Co-authored-by: Mitchell Crompton <mitchell.crompton@tiny.cloud>

* DOC-2235: changes and updates to  page. (#3039)

* DOC-2240: add new `understanding-editor-loads.adoc` to `how-to-guide` section (#3047)

* DOC-2240: add new understanding-editor-loads.adoc to how-to-guide section.

* Update modules/ROOT/pages/understanding-editor-loads.adoc

* Update modules/ROOT/pages/understanding-editor-loads.adoc

Co-authored-by: Andrew Herron <andrew.herron@tiny.cloud>

* Update modules/ROOT/pages/understanding-editor-loads.adoc

Co-authored-by: Andrew Herron <andrew.herron@tiny.cloud>

* Update modules/ROOT/pages/understanding-editor-loads.adoc

* Update modules/ROOT/pages/understanding-editor-loads.adoc

removed this for future updates

* Update changelog.md

---------

Co-authored-by: Andrew Herron <andrew.herron@tiny.cloud>

* DOC-2275: updates to `cloud-troubleshooting.adoc` with new links to `invalid-api-key.adoc` page. (#3055)

* updates to  with new links to  page.

* make it clearer that there are two causes and solutions for the first issue

* undo previous commit 01fbca7

* DOC-2275: fixing up heading levels and document styling.

* Update changelog.md

---------

Co-authored-by: Farzad Hayatbakhsh <farzad.hayatbakhsh@tiny.cloud>

* DOC-2276: updates to `cloud-troubleshooting.adoc` with new `read-only` ref and links to `invalid-api-key.adoc` page. (#3056)

* DOC-2276: updates to  with new  ref and links to  page.

* Update modules/ROOT/pages/cloud-troubleshooting.adoc

* Update changelog.md

* DOC-2241: TinyMCE 6.8.3 release notes (#3048)

* DOC-2241: added 6.8.3-release-notes.adoc to project.

* DOC-2241: added fix documentation for TINY-10449, TINY-10451 and TINY-10335.

* Update modules/ROOT/nav.adoc

Co-authored-by: Farzad Hayat <farzad.hayatbakhsh@tiny.cloud>

* DOC-2241: add Accompanying Premium self-hosted server-side component changes.

* Update modules/ROOT/pages/6.8.3-release-notes.adoc

* Update changelog.md

* Update modules/ROOT/pages/6.8.3-release-notes.adoc

* Update modules/ROOT/pages/6.8.3-release-notes.adoc

---------

Co-authored-by: Farzad Hayat <farzad.hayatbakhsh@tiny.cloud>

* DOC-2242: Added 6.8.3-specific entry to `changelog.adoc`. (#3049)

* DOC-2242: Added 6.8.3-specific entry to .

* update old link in README.md

* Update link in README.md to point to release

Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>

* Update changelog.md

* Update modules/ROOT/pages/changelog.adoc

* Update changelog.adoc

Co-authored-by: tiny-ben-tran <ben.tran@tiny.cloud>

* Update modules/ROOT/pages/changelog.adoc

* DOC-2242: bump .api-version for tinymce 6.8.3 docs.

---------

Co-authored-by: Farzad Hayatbakhsh <farzad.hayatbakhsh@tiny.cloud>
Co-authored-by: tiny-ben-tran <ben.tran@tiny.cloud>

* DOC-2281: updates to `cloud-troubleshooting.adoc` with new `link` directs to `domain-not-registered`. (#3059)

* DOC-2281: updates to cloud-troubleshooting.adoc with new link directs to domain-not-registered.

* Update changelog.md

---------

Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
Co-authored-by: Andrew Herron <andrew.herron@tiny.cloud>
Co-authored-by: Farzad Hayatbakhsh <farzad.hayatbakhsh@tiny.cloud>
Co-authored-by: tiny-ben-tran <ben.tran@tiny.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiridiGandham ShiridiGandham ShiridiGandham approved these changes

@TheSpyder TheSpyder TheSpyder approved these changes

@mhideo mhideo Awaiting requested review from mhideo

@Afraithe Afraithe Awaiting requested review from Afraithe Afraithe was automatically assigned from tinymce/documentation-team

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999 MitchC1999 was automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kemister85 @TheSpyder @ShiridiGandham