Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in new docs #4363

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

smurfd
Copy link
Contributor

@smurfd smurfd commented Apr 30, 2024

Updating links in docs/ to point towards https://github.com/tinygrad/tinygrad/blob/master instead of https://tinygrad.github.io/, ie making them work :)

@wozeparrot
Copy link
Collaborator

I feel like some of these should point to the hosted docs instead, like references to tensor.py and nn

@smurfd
Copy link
Contributor Author

smurfd commented Apr 30, 2024

Im more than happy to change if something is not correct :)
But i believe the hosted docs are .md files, like: https://github.com/tinygrad/tinygrad/blob/master/docs/tensor.md and the links touched here are only .py and from context it makes some sense. They also point to subfolders like tinygrad/tensor.py for example or tinygrad/nn/__init__.py

@wozeparrot
Copy link
Collaborator

I think it might be better to rewrite them to point to the tensor.md docs since that's the docs that are nicer for new users.

tensor and nn links to tensor.md and nn.md
@smurfd smurfd force-pushed the modify-links-in-docs branch from 423b24e to cad3b4f Compare April 30, 2024 22:58
Copy link
Contributor

This branch currently is behind tinygrad/master. The line count difference bot is disabled.

@smurfd
Copy link
Contributor Author

smurfd commented Apr 30, 2024

thanks, updated with nn.md and tensor.md. but kept one for tensor where the example copied the sparse_categorical_crossentropy() function

@geohot geohot merged commit cc33947 into tinygrad:master May 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants