Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aztec #9

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Add Aztec #9

merged 3 commits into from
Apr 1, 2024

Conversation

TheNeverMan
Copy link
Contributor

Add Aztec theme to repository. (https://github.com/TheNeverMan/aztec-base16/)

Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 😄 Can you remove the one comment? It doesn't add anything since the information is already contained within the yaml content itself. Once you remove it I'll merge the PR.

@@ -0,0 +1,22 @@
# Aztec scheme for the Base16 Builder (https://github.com/chriskempson/base16-builder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I just copied yaml template from another theme within the repo, thought it is descriptive and appropriate.

base05: "FFDA51" # Foreground --
base06: "FFE178" # Foreground ---
base07: "FFEBA0" # Foreground ----
base08: "EE2E00" # Red

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh love the comments here. Cheers :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the template from yaml file of 3024 theme. Thank contributor of that theme instead of me.

@TheNeverMan
Copy link
Contributor Author

File is updated. I removed the comment.

Copy link

@FredHappyface FredHappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@JamyGolden JamyGolden merged commit 029612d into tinted-theming:spec-0.11 Apr 1, 2024
@TheNeverMan
Copy link
Contributor Author

It is going to be automatically added to base16 gallery, right?

@JamyGolden
Copy link
Member

Yeah the builds happen every sunday, but I'll manually run it in the gallery now (the rest of the templates will be updated this sunday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants