Update the scaling out section #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
requested review from
pmwkaa,
mkindahl,
k-rus,
niksajakovljevic,
feikesteenbergen,
solugebefola and
WireBaron
feikesteenbergen
approved these changes
Oct 22, 2019
mkindahl
reviewed
Oct 22, 2019
getting-started/scaling-out.md
Outdated
| * You should already have a running PostgreSQL server on an instance | ||
| that will host a data node database. The data node's database will | ||
| be created when executing the `add_data_node` command on the access | ||
| node and should _not_ exist prior to adding the data node. |
There was a problem hiding this comment.
It can exist, it will not fail, but it might be good to not encourage it.
/* Create the database with the user as owner. This command might fail
* if the database already exists, but we catch the error and continue
* with the bootstrapping if it does. */
res = remote_connection_execf(conn,
"CREATE DATABASE %s OWNER %s",
quote_identifier(dbname),
quote_identifier(username));
There was a problem hiding this comment.
Question is if we should delve into the subtleties of this here. I do say should and not must. I figure we'd keep it simple here.
getting-started/scaling-out.md
Outdated
| distributed hypertables). Currently, such roles and permissions need | ||
| to be created manually, although there is a [utility | ||
| command][distributed_exec] that can be used to create roles and | ||
| permissions across all (or a subset of) data nodes. |
There was a problem hiding this comment.
Suggest to remove "all (or a subset of) ".
getting-started/scaling-out.md
Outdated
Comment on lines
57
to
59
| certificate authentication. Other ways of authenticating may be | ||
| supported in the future. |
There was a problem hiding this comment.
Suggest to focus on what we have now, the last sentence is redundant.
getting-started/scaling-out.md
Outdated
| `add_data_node` expects to be able to create a | ||
| database on the remote data node and create | ||
| a TimescaleDB extension within it. | ||
| * Provide the host name (and optionally port) of the PostgreSQL |
There was a problem hiding this comment.
Suggest "...host name, and optionally port, of the PostgreSQL..."
Comment on lines
+68
to
+69
| * Ensure that non-superusers have `USAGE` privileges on the | ||
| `timescaledb_fdw` foreign data wrapper and any | ||
| data node objects they will use on the access node. |
There was a problem hiding this comment.
Hmmm.... maybe something we might consider to do automatically when adding the data node. No action here though.
solugebefola
requested changes
Oct 22, 2019
getting-started/scaling-out.md
Outdated
|
|
||
| * You should already have a running PostgreSQL server on the data node host. | ||
| * You should already have a running PostgreSQL server on an instance | ||
| that will host a data node database. The data node's database will |
There was a problem hiding this comment.
Suggested change
| that will host a data node database. The data node's database will | |
| that will host a data node. The data node's database will |
getting-started/scaling-out.md
Outdated
| Any additional users that will access a distributed hypertable currently | ||
| need their own user mappings per data node with a `user` and `password` option. | ||
| A user mapping can be created for a data node as follows: | ||
| * Ensure that each user of a distributed hypertable have a way to |
There was a problem hiding this comment.
Suggested change
| * Ensure that each user of a distributed hypertable have a way to | |
| * Ensure that each user of a distributed hypertable has a way to |
getting-started/scaling-out.md
Outdated
| ``` | ||
|
|
||
| This will prohibit any new data to be stored on the data node. Once |
There was a problem hiding this comment.
Suggested change
| This will prohibit any new data to be stored on the data node. Once | |
| This will prohibit any new data from being stored on the data node. Once |
erimatnor
force-pushed
the
enordstr/update-scaling-out
branch
from
98f0af2 to
933750e
Compare
This updates the scaling out section to be up-to-date with the latest multinode APIs and functionality.
erimatnor
force-pushed
the
enordstr/update-scaling-out
branch
from
933750e to
a29b2a3
Compare
solugebefola
approved these changes
Oct 22, 2019
| * Ensure that the local user has `USAGE` privileges on the `timescaledb_fdw` | ||
| foreign data wrapper on the access node. | ||
| * Ensure that each user of a distributed hypertable has a way to | ||
| [authenticate][data-node-authentication] with the data nodes they |
There was a problem hiding this comment.
I'm assuming the page-index.js will have been modified to accommodate this page (from the other PR)?
There was a problem hiding this comment.
I'm assuming that too :)
k-rus
pushed a commit
that referenced
this pull request
Jul 14, 2020
This updates the scaling out section to be up-to-date with the latest multinode APIs and functionality.
mamm0thz
pushed a commit
that referenced
this pull request
Jul 30, 2020
This updates the scaling out section to be up-to-date with the latest multinode APIs and functionality.
mamm0thz
pushed a commit
that referenced
this pull request
Jul 30, 2020
This updates the scaling out section to be up-to-date with the latest multinode APIs and functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the scaling out section to be up-to-date with the latest
multinode APIs and functionality.