Fix phpstan tests #2886
Merged
Fix phpstan tests #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Lately some tests fail. This PR focusses on getting the phpstan tests running again while also tackeling two other phpstan errors I got locally.
Solution
Include a file to discover symbols, changing a property name and ignore an ACF function error.
Impact
PHPSTAN tests that run again.
Usage Changes
no
Considerations
I got 20 more errors when running phpstan, mostly the unsafe use of new static(), we might want to ignore that as well? Other errors are also some other missing symbols. Let me know if we want to look into those as well.