fix: Fix bug with Attachment::path() method #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tial URL. Co-authored-by: Luka Juras <mrfsrf@gmail.com>
Levdbas
changed the title
gchtr
changed the title
gchtr
reviewed
Dec 17, 2024
gchtr
approved these changes
Dec 17, 2024
Levdbas
deleted the
3072-timberattachmentpath-returns-incorrect-value
branch
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Solution was provided by @mrfsrf
Issue
When
'Timber\Attachment::path(); is requested, the Path ends up being a mix of a path and a URL.Solution
If we are working with a URL, the convert the path first to a filesystem path before getting the relative path.
Impact
A method that works again.
Usage Changes
No.
Considerations
Do we need to run the is_url check first since we are probably working with a URL anyway?
Testing
Yes, test added.