Use snapshots for errors that dplyr owns now #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess these are a little awkward because the snapshot error will change depending on if you have dev or CRAN dplyr. On second thought, I'll render them with CRAN dplyr and then when 1.1.0 is released you can update them (with no pressure from CRAN) |
|
Sounds good, thanks @DavisVaughan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes your package compatible with the next version of dplyr:
slice_*()now handles some of the checks in the generic itself, and the error messages it throws are different from what you had before. I've made these snapshot error tests since dplyr really owns the error message now, and we don't want this to fail on CRAN if dplyr ever changes it.We plan to submit dplyr 1.1.0 on January 27th.
This should be compatible with both dev and CRAN dplyr. It would help us out if you could go ahead and send a patch version of your package to CRAN ahead of time! Thanks!