Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidyselect v1.2.0 updates #393

Merged
merged 9 commits into from
Oct 17, 2022
Merged

tidyselect v1.2.0 updates #393

merged 9 commits into from
Oct 17, 2022

Conversation

markfairbanks
Copy link
Collaborator

@markfairbanks markfairbanks commented Oct 12, 2022 •
edited
Loading

Overview:

  • Implement tidyselect_data_proxy() and tidyselect_data_has_predicates() dtplyr_step methods
  • Remove internal dtplyr_tidyselect()
  • Use eval_relocate() in relocate()

@markfairbanks markfairbanks requested a review from eutwt October 12, 2022 19:59
@markfairbanks markfairbanks mentioned this pull request Oct 14, 2022
Merged
eutwt
eutwt approved these changes Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@eutwt eutwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markfairbanks markfairbanks removed the request for review from mgirlich October 17, 2022 14:56
@markfairbanks markfairbanks merged commit 55e9298 into main Oct 17, 2022
@markfairbanks markfairbanks deleted the tidyselect-1.2.0 branch October 17, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eutwt eutwt eutwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markfairbanks @eutwt