Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the versions of gjson and pretty #41

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

ysmood
Copy link
Contributor

@ysmood ysmood commented Aug 28, 2020

So that other projects doesn't have to download multiple versions of the gjson.
Here's a sample go.sum file if we don't sync the versions, as you can see we have pretty v1.0.0 and v1.0.1:

github.com/tidwall/pretty v1.0.0/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=
github.com/tidwall/pretty v1.0.1 h1:WE4RBSZ1x6McVVC8S/Md+Qse8YUv6HRObAx6ke00NY8=
github.com/tidwall/pretty v1.0.1/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=

So that other projects doesn't have to download multiple versions of the gjson.
Here's a sample go.sum file if we don't sync the versions, as you can see we have pretty v1.0.0 and v1.0.1:

github.com/tidwall/pretty v1.0.0/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=
github.com/tidwall/pretty v1.0.1 h1:WE4RBSZ1x6McVVC8S/Md+Qse8YUv6HRObAx6ke00NY8=
github.com/tidwall/pretty v1.0.1/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=
@ysmood
Copy link
Contributor Author

ysmood commented Sep 30, 2020

@tidwall Hi, can you check this PR?

@tidwall tidwall merged commit 79e91a7 into tidwall:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants