Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): production builds using aot compiler #12268

Merged
merged 3 commits into from
Jan 11, 2021
Merged

fix(angular): production builds using aot compiler #12268

merged 3 commits into from
Jan 11, 2021

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-28205

Optional Description:

Updates the Angular template to fix errors in production builds and properly enable AoT compilation for improved performance.

@build build added this to the 9.3.0 milestone Nov 17, 2020
@build
Copy link
Contributor

build commented Nov 17, 2020 •
edited
Loading

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 15350 tests are passing.
(There are 916 skipped tests not included in that total)

Generated by 🚫 dangerJS against 2324fc5

ewanharris
ewanharris approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR pass, tested packaging and android/ios device builds also and looks good

@sgtcoolguy sgtcoolguy modified the milestones: 9.3.0, 10.0.0 Nov 20, 2020
@lokeshchdhry
Copy link
Contributor

FR Passed.
Packaging angular app works as expected.

@lokeshchdhry lokeshchdhry merged commit a3a6459 into tidev:master Jan 11, 2021
@build build mentioned this pull request Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@janvennemann @build @lokeshchdhry @ewanharris @sgtcoolguy