Limit number of parallel frames being painted #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #67, we started painting frames in parallel instead of serially, in order to fully utilize available CPU. But we did this without any limit. So if a `Root` had hundreds of frames, we would attempt to paint all of them in parallel. This would consume huge amounts of memory by allocating hundreds or thousands of image buffers. Instead, we now limit parallelism to the number of CPU's.
|
Tested with a couple apps that paint hundreds of frames (Arcade Classics, Climate Clock). They render just as quickly with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #67, we started painting frames in parallel instead of serially, in
order to fully utilize available CPU.
But we did this without any limit. So if a
Roothad hundreds of frames,we would attempt to paint all of them in parallel. This would consume
huge amounts of memory by allocating hundreds or thousands of image
buffers.
Instead, we now limit parallelism to the number of CPU's.