Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data loading from D4RL and convert RL Unplugged to D4RL format #624

Merged
merged 7 commits into from
May 3, 2022

Conversation

nuance1979
Copy link
Collaborator

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Improve data loading from D4RL and convert RL Unplugged data to D4RL format following the discussion.

@nuance1979
Copy link
Collaborator Author

@Trinkle23897 I will make the change in all d4rl_*.py and atari_*.py files once you are ok with this PR.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #624 (0deba1e) into master (dd16818) will increase coverage by 0.05%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   93.50%   93.56%   +0.05%     
==========================================
  Files          68       68              
  Lines        4556     4567      +11     
==========================================
+ Hits         4260     4273      +13     
+ Misses        296      294       -2     
Flag Coverage Δ
unittests 93.56% <90.90%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/buffer/base.py 98.91% <90.90%> (-0.51%) ⬇️
tianshou/policy/modelfree/trpo.py 94.91% <0.00%> (+5.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented May 1, 2022

@Trinkle23897 I will make the change in all d4rl_*.py and atari_*.py files once you are ok with this PR.

Sure, please go ahead.

@Trinkle23897
Copy link
Collaborator

How about using a function in utils.py so that we don't need to change it everywhere?

@nuance1979
Copy link
Collaborator Author

How about using a function in utils.py so that we don't need to change it everywhere?

Sure. I can do that.

@Trinkle23897 Trinkle23897 merged commit a7c789f into thu-ml:master May 3, 2022
@nuance1979 nuance1979 deleted the convert_rl_unplugged branch June 1, 2022 17:14
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants